Skip to content

Gate period filter behind ?q=v2, limit sorting to Last Seen only#3847

Merged
sarupbanskota merged 1 commit into
mainfrom
fix/team-members-gate-features
Apr 9, 2026
Merged

Gate period filter behind ?q=v2, limit sorting to Last Seen only#3847
sarupbanskota merged 1 commit into
mainfrom
fix/team-members-gate-features

Conversation

@sarupbanskota

Copy link
Copy Markdown
Member

Summary

  • Duration dropdown only renders when ?q=v2 is in the URL (hidden while we debug time-filtered counts)
  • Removed sorting from all columns except Last Seen
  • Default sort restored to original behavior: attempts desc, then last seen desc, then joined desc
  • Last Seen sort toggles: desc -> asc -> back to default

Test plan

  • npx ember test --filter="manage-team-members" — 3/3 pass
  • Without ?q=v2: no dropdown visible, only Last Seen column is clickable for sorting
  • With ?q=v2: dropdown appears and functions

🤖 Generated with Claude Code

…t Seen only

- Duration dropdown only renders when ?q=v2 is in the URL
- Removed sorting from all columns except Last Seen
- Default sort restored to original: attempts desc, last seen desc, joined desc
- Last Seen sort toggles: desc -> asc -> default
@sarupbanskota sarupbanskota merged commit d2567f5 into main Apr 9, 2026
1 of 4 checks passed
@sarupbanskota sarupbanskota deleted the fix/team-members-gate-features branch April 9, 2026 05:20
@codecov

codecov Bot commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/team-page/members-table.ts 33.33% 6 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@codecov

codecov Bot commented Apr 9, 2026

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 32 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
client-array-push 39.48MB -32 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/chunk.*.js -32 bytes 3.44MB -0.0%

Files in assets/chunk.*.js:

  • ./controllers/team.ts → Total Size: 341 bytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant